Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix securityContext settings in job template #1086

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

andreasgeisslerdt
Copy link
Contributor

@andreasgeisslerdt andreasgeisslerdt commented Jul 2, 2024

Intends needed to be fixed and containerSecurityContext value settings are used

What this PR does / why we need it:

When I want to use the options:

securityContext:
  runAsGroup: 65534
  runAsNonRoot: true
  runAsUser: 65534
  seccompProfile:
    type: RuntimeDefault
containerSecurityContext:
  allowPrivilegeEscalation: false
  capabilities:
    drop:
    - ALL
    - CAP_NET_RAW

the entries will not be set correctly in the resulting manifest

**Which issue this PR fixes:

fixes: #1087

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

Intends needed to be fixed and containerSecurityContext value settings are used
Copy link
Collaborator

@AssahBismarkabah AssahBismarkabah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello @andreasgeisslerdt
The changes look good, but please update the CHANGELOG.md to reflect these security context modifications
thank you

@AssahBismarkabah
Copy link
Collaborator

Hi @andreasgeisslerdt , it will be nice if the conflicts with the base branch can be resolved.

Copy link

sonarcloud bot commented Oct 8, 2024

@francis-pouatcha francis-pouatcha merged commit 4d2c821 into adorsys:main Oct 15, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

SecurityContext settings in job template is wrong
3 participants