-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for managing client-policies #865
Add support for managing client-policies #865
Conversation
@st3v0rr I think the current CI build failures are unrelated to this PR, would you mind taking a look? All test runs fail with this test:
|
@st3v0rr I think this PR is ready now for review, would you mind taking a look? |
@st3v0rr I just noticed that I forgot to click "ready for review". I just updated the PR. Could you take a look? |
- Skip update of new and current profiles are null
- Add missing testcase - Update FEATURES.md
1c4f835
to
a83e9d7
Compare
Rebased on current main |
Codecov Report
@@ Coverage Diff @@
## main #865 +/- ##
============================================
+ Coverage 95.45% 95.50% +0.05%
- Complexity 1304 1322 +18
============================================
Files 76 78 +2
Lines 4220 4272 +52
Branches 469 475 +6
============================================
+ Hits 4028 4080 +52
+ Misses 94 91 -3
- Partials 98 101 +3
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
What this PR does / why we need it:
Adds support for managing client-profiles.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #fixes #863
Special notes for your reviewer:
Some executors such as
secret-rotation
in client-policies are only available in recent Keycloak versions.PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR