Update to Keycloak 22.0.0 #899
Conversation
|
I guess the PR of Thomas should be more promising, but I wanted to also add my changes to the POM, maybe we need the best of both worlds ;) Please work on that one: #898 |
jonasvoelcker
changed the title
jonasvoelcker
changed the title
|
@jonasvoelcker Thanks for your contribution! Your PR uses the same approach as I did, so that was a good start already ;-) However the real challenge is to get the changes in a form that works across versions. The "hack" in my PR is that I replace the jakarta to javax packages again and change the rest easy version back via sed before building older versions. I don't know how sustainable this is in the long run, but this seems to work so far. How about joining forces and work together on the other PR? :) |
| @@ -160,6 +155,12 @@ | |||
| <dependency> | |||
| <groupId>org.springframework.boot</groupId> | |||
| <artifactId>spring-boot-starter</artifactId> | |||
| <exclusions> | |||
There was a problem hiding this comment.
I think it would make sense to have the different dependencies guarded with a profile.
Perhaps have a default profile that uses the new jakarta ee deps and an "javax" profile, which uses the old dependencies?
There was a problem hiding this comment.
An interesting thought, normally I do write services that follow one simple ruleset which perfectly fits the surrounding services. Frameworks with multiple supported versions are completely new for me. ;)
|
@thomasdarimont Unfortunately we are in the situation that we need to go live sooner than we would like to. We have many other things to solve and didn't start with configuration as code yet. So I am afraid, that I won't be able to contribute much. I will definitely check out your branch and try some things and maybe I'll try a little but I think you can't count on me for now, sorry. |
|
@jonasvoelcker thanks you for your honest feedback! The PR #898 seems to be on the finishing line. Maybe you will still find time to try it out :) |
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## main #899 +/- ##
============================================
+ Coverage 95.45% 95.54% +0.09%
- Complexity 1304 1306 +2
============================================
Files 76 76
Lines 4220 4224 +4
Branches 469 469
============================================
+ Hits 4028 4036 +8
+ Misses 94 91 -3
+ Partials 98 97 -1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Closed in favor of this one: #898 |
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR