Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Multiple Usage of Authenticators/Conditions in Authentication Sub-Flows #980

Conversation

f11h
Copy link
Contributor

@f11h f11h commented Jan 16, 2024

What this PR does / why we need it:

Which issue this PR fixes: fixes #978

Special notes for your reviewer:

See Linked Bug-Ticket for detailed description of the problem.
Subflow-Executions are created without special configuration and then modified according the definiton in the input file. This requires the config-tool to query keycloak for the created execution. If we have multiple executions with different configs within one subflow they could not be found distinguished.
This PR adds a filter to the repository method to return executions with corect "alias"/"configuration" which finally allows users to have sub flows with usage of same authenticators/conditions.

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@f11h f11h force-pushed the fix/auth-flow-with-multiple-executions-of-same-type branch from 2c06842 to 1b2de41 Compare January 16, 2024 14:58
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.57%. Comparing base (554c4a1) to head (e0c1167).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #980   +/-   ##
=========================================
  Coverage     95.56%   95.57%           
- Complexity     1370     1373    +3     
=========================================
  Files            81       81           
  Lines          4400     4405    +5     
  Branches        500      500           
=========================================
+ Hits           4205     4210    +5     
  Misses           94       94           
  Partials        101      101           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@f11h f11h force-pushed the fix/auth-flow-with-multiple-executions-of-same-type branch from 1b2de41 to 89c7593 Compare January 16, 2024 15:03
Copy link

sonarcloud bot commented Jan 16, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@f11h
Copy link
Contributor Author

f11h commented Jan 16, 2024

Test for KC 23.0.1 are failing:

[ERROR]   ImportParallelImportIT.shouldCreateRealm:52->AbstractImportTest.doImport:73->AbstractImportTest.doImport:80 » ImportProcessing
[ERROR]   ImportParallelImportIT.shouldUpdateRealm:60->AbstractImportTest.doImport:73->AbstractImportTest.doImport:80 » WebApplication

Did not modify anything in this direction - Is this a known problem?

Copy link

sonarcloud bot commented Apr 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@francis-pouatcha francis-pouatcha self-assigned this Sep 24, 2024
@AssahBismarkabah
Copy link
Collaborator

Hi @f11h,

I tested your PR locally, and all tests passed successfully. The changes work as intended!

However, the GitHub workflow is failing due to errors in ImportParallelImportIT during realm creation and updates. This might not be directly related to your changes, but it’s worth checking. Also, the line:

.filter((config) -> config.getAuthenticatorConfig().equals("config-1"))
    .collect(Collectors.toList());

seems to be missing the Collectors import, which might be causing the issue. Additionally, there are conflicts with the main branch that need resolving. If you need help with this or reviewing the failed tests, just let me know!

Thanks for your hard work!

Copy link

sonarcloud bot commented Oct 15, 2024

@francis-pouatcha francis-pouatcha merged commit 46d83c1 into adorsys:main Oct 17, 2024
13 checks passed
@f11h f11h deleted the fix/auth-flow-with-multiple-executions-of-same-type branch October 17, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

AuthenticatorFlow with multiple authenticationExecutions of same type in Sub-Flow leads to exception
3 participants