-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Multiple Usage of Authenticators/Conditions in Authentication Sub-Flows #980
Fix: Multiple Usage of Authenticators/Conditions in Authentication Sub-Flows #980
Conversation
2c06842
to
1b2de41
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #980 +/- ##
=========================================
Coverage 95.56% 95.57%
- Complexity 1370 1373 +3
=========================================
Files 81 81
Lines 4400 4405 +5
Branches 500 500
=========================================
+ Hits 4205 4210 +5
Misses 94 94
Partials 101 101 ☔ View full report in Codecov by Sentry. |
1b2de41
to
89c7593
Compare
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Test for KC 23.0.1 are failing:
Did not modify anything in this direction - Is this a known problem? |
Quality Gate passedIssues Measures |
Hi @f11h, I tested your PR locally, and all tests passed successfully. The changes work as intended! However, the GitHub workflow is failing due to errors in .filter((config) -> config.getAuthenticatorConfig().equals("config-1"))
.collect(Collectors.toList()); seems to be missing the Thanks for your hard work! |
Quality Gate passedIssues Measures |
What this PR does / why we need it:
Which issue this PR fixes: fixes #978
Special notes for your reviewer:
See Linked Bug-Ticket for detailed description of the problem.
Subflow-Executions are created without special configuration and then modified according the definiton in the input file. This requires the config-tool to query keycloak for the created execution. If we have multiple executions with different configs within one subflow they could not be found distinguished.
This PR adds a filter to the repository method to return executions with corect "alias"/"configuration" which finally allows users to have sub flows with usage of same authenticators/conditions.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR