-
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preparing for Release 1.0.0 #252
Conversation
import cafe.adriel.voyager.hilt.getScreenModel | ||
import cafe.adriel.voyager.navigator.LocalNavigator | ||
import cafe.adriel.voyager.navigator.currentOrThrow | ||
|
||
class LegacyScreenOne : AndroidScreen() { | ||
class LegacyScreenOne : Screen { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why AndroidScreen
was removed in samples? Will be there any replacement of it and it's ScreenLifecycleProvider implementation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The AndroidScreenLifecycle is now default for all screens on Android, has been for the last few builds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Import to notice here is that: for folks that are using blinding AndroidScreen there will be a single behavior change comparing it with Screen
.
Currently AndroidScreen
holds a unique Id for each new instance of the Screen, this is already documented usage of the library and will be documented in the future "Migration guides".
But how @Syer10 point out, the ScreenLifecycleProvider
behavior that AndroidScreen had, is no longer required anymore, is the default behavior for all screen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the clarification!
@DevSrSouza can we take a look in TabOptions api design? the current design has "expected standards" for Android like And it's also a little complicated to create these options like See #141 |
Yes, we can look into this in next versions and also be backwards compatible. |
bb6e145
to
345c33c
Compare
AndroidScreen