-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update project build configuration and dependencies #514
Open
dzmpr
wants to merge
10
commits into
adrielcafe:main
Choose a base branch
from
dzmpr:dependencies_update
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…guration logic to convention plugins
Vodes
reviewed
Dec 15, 2024
mavenPublish = "0.30.0" | ||
composeMultiplatform = "1.7.1" | ||
binaryCompatibilityValidator = "0.16.3" | ||
atomicfu = "0.26.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fyi, this will currently cause an issue because compose expects (and forces) 0.23.2.
Seems to be a known issue https://youtrack.jetbrains.com/issue/CMP-5831
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
I have some troubles with m2 bottom sheet navigator so I decided to add m3 bottom sheet navigator and solve this problem for me and for others. But when I started working on it I saw that voyager uses compose multiplatform 1.6.11 when I needed 1.7. One after another I'm ended up made some improvement to project build configuration and updated all dependencies (not only compose kmp).
So, what's have been done:
.gitignore
andcustomer.proguard.pro
files.buildSrc
and replace it withbuild-config
included build. WithbuildSrc
there are problems with using version catalogs and no pros.appcompat
,compose-runtimeSaveable
,compose-compiler
,compose-animations
, and maybe something else). Note: this compose dependencies are not multiplatform and only used in samples.com.benasher44:uuid
dependency with kotlin stdlib implementation which is available from kotlin 2.0.compileOnly
for compose dependencies with plainimplementation
as now seems all working fine but withcompileOnly
compiler threw warnings about js targets.What's I left behind:
jvm("desktop")
target which triggers compiler warning).ExperimentalVoyagerApi
fromnonPublicMarkers
(I consider this is a mistake, because it' actually public api, just experimental). So if you are okay with this I update api with additional commit.I've tested all samples on android and following targets of multiplatform sample: js, wasm, macos (not sure what target).
So I'm waiting for review, and open for any questions if you have one.