fix: scope parameter from medusa-config.js not passed through to passport #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… passed through to passport
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
adrien2p
requested changes
Jun 8, 2024
added 2 commits
June 10, 2024 19:13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to extend the scope of the token request to Microsoft Entra in order to receive the claims that I needed.
For that, setting the scope parameter in the passportAuthenticateMiddlewareOptions was not enough, since passport (at least for version 0.6.0) determines the scope from the argument "options" passed to the constructor of the strategy.
I hope you are fine with me bumping the version and writing to the changelog. I'm sorry if you're not. It's my first pull request.