-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Column number override #34
base: master
Are you sure you want to change the base?
Conversation
Introduces a new option to manually set the number of columns in the layout. If 0, the usual autosensing applies. Layout is now regenerated every time the SettingsDialog is closed with ok. This might be unwanted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @sassospicco, looks good!
Would it be possible for you to change the settings appearance? I'm thinking about something like:
Layout
------
[x] automatic number of columns: | |
@@ -385,7 +393,7 @@ def set_settings(self, button): | |||
dialog.apply_opts(self.opts) | |||
dialog.destroy() | |||
if self.history: | |||
self.render_preview() | |||
self.regenerate_layout() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please regenerate layout only if the number of cols changed. Users don't want their collage to change if they just chose a different border color.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adrienverge, I see that it has not been decided for a long time. I can reopen this PR with line self.regenerate_layout() instead of self.render_preview(). Ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andreynovikov95 I'm not sure it's a good idea, as this PR would bring more complexity to the tool, which is not needed here. But thanks for proposing!
Hi, thanks for your software!
I introduced the ability to manually set the number of columns. I find it quite useful, since the new auto-layout algorithm introduced in 1.4 generates strange grids sometimes.
This is a quick-and-dirty implementation, feel free to do whatever you please with it :)