Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visualization issue #570

Merged
merged 2 commits into from
Dec 7, 2024
Merged

Fix visualization issue #570

merged 2 commits into from
Dec 7, 2024

Conversation

thostetler
Copy link
Member

@thostetler thostetler commented Dec 7, 2024

Instead of using dynamic imports for these CJS modules, this fix uses nextjs config

Also removes the dynamic load for the landing page, which was a little jumpy when first loading the site.

For testing you can do pnpm build:local && pnpm start:local to do a local production build

Instead of using dynamic imports for these CJS modules, this fix uses nextjs config

Also removes the dynamic load for the landing page, which was a little jumpy when first loading the site
@thostetler thostetler requested a review from shinyichen December 7, 2024 01:23
Copy link

codecov bot commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.1%. Comparing base (d061e52) to head (8a13ecb).
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #570      +/-   ##
=========================================
+ Coverage    51.7%   66.1%   +14.5%     
=========================================
  Files         319     197     -122     
  Lines       37742   22146   -15596     
  Branches      632     584      -48     
=========================================
- Hits        19480   14627    -4853     
+ Misses      18252    7509   -10743     
  Partials       10      10              

see 130 files with indirect coverage changes

@thostetler thostetler merged commit a74fabc into adsabs:master Dec 7, 2024
5 checks passed
@thostetler thostetler deleted the fix-viz branch December 7, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants