Skip to content

Citation bulk fetch #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Conversation

shinyichen
Copy link
Member

Fetch citations in bulk

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.1%. Comparing base (e4d1e78) to head (74fe5fb).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #572     +/-   ##
========================================
+ Coverage    66.1%   66.1%   +0.1%     
========================================
  Files         197     197             
  Lines       22146   22146             
  Branches      585     585             
========================================
+ Hits        14625   14627      +2     
+ Misses       7511    7509      -2     
  Partials       10      10             

see 1 file with indirect coverage changes

Copy link
Member

@thostetler thostetler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think the one method needs to have better error handling.

Copy link
Member

@thostetler thostetler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@shinyichen shinyichen merged commit b978c59 into adsabs:master Dec 17, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants