Skip to content

Fix facet bug when an operator word is in the filter string #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

shinyichen
Copy link
Member

@shinyichen shinyichen commented Mar 13, 2025

Found this bug when applying UAT keyword filter 'galactic and extragalactic astronomy. The and was converted to capitalized and that seemed to turn into the 'and' operator and messed up the results.

The fix: apply operator capitalization outside of quotes.

Screen.Recording.2025-03-13.at.2.15.54.PM.mov

@shinyichen shinyichen requested a review from thostetler March 13, 2025 21:21
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.2%. Comparing base (30164ec) to head (3e3836d).
Report is 6 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #604   +/-   ##
======================================
  Coverage    66.2%   66.2%           
======================================
  Files         203     203           
  Lines       22834   22834           
  Branches      621     621           
======================================
  Hits        15114   15114           
  Misses       7708    7708           
  Partials       12      12           
Files with missing lines Coverage Δ
src/query.ts 96.6% <100.0%> (ø)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@thostetler thostetler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice!

@shinyichen shinyichen merged commit 2385a8b into adsabs:master Mar 14, 2025
4 checks passed
@shinyichen shinyichen deleted the SCIX-512-facet-bug-operator-word-in-filter branch March 14, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants