Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove playwright and storybook #606

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

thostetler
Copy link
Member

In an effort to cleanup the repo some this PR.

  • Remove Storybook and config
  • Remove Playwright and test files in favor of the dedicated repo
  • Some test improvements and cleanup
  • Fixes typing issue in test-utils

@shinyichen if you find storybook to be essential to your workflow please let me know, we can let it back in. I haven't been keeping up with it recently and it just adds boilerplate to the tests

@thostetler thostetler requested a review from shinyichen March 20, 2025 21:45
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.9%. Comparing base (2385a8b) to head (1f7f4d2).

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #606     +/-   ##
========================================
+ Coverage    66.0%   66.9%   +1.0%     
========================================
  Files         204     181     -23     
  Lines       22931   19342   -3589     
  Branches      621     693     +72     
========================================
- Hits        15127   12937   -2190     
+ Misses       7792    6393   -1399     
  Partials       12      12             
Files with missing lines Coverage Δ
src/components/LandingTabs/LandingTabs.tsx 93.3% <100.0%> (+68.7%) ⬆️
src/test-utils.tsx 88.5% <100.0%> (-0.3%) ⬇️

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant