Tweaks to custom metadata provider schema #2891
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When developing my custom metadata provider, I noticed a couple of issues with the provider schema that I thought I would fix. I also did a bit of minor tidy up (I hope this is ok, If not let me know and I will revert!)
Schema changes:
duration
type should be an integer not a numberSeriesMetadata
to its own component, as this will generate its own type for those who use generators with the schema, instead of nested anonymous objects.series
under SeriesMetadata being required was specified in the incorrect way usingrequired: <bool>
instead ofrequired: <property array>
sequence
under SeriesMetadata should not be a number, it should be a string to allow for sequences like0.5
,1-3
and1,3,5
Let me know if there is any changes you would like me to make!