Add bookSeries id attribute to findAllExpandedWhere #3898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary
Adds
bookSeries.idattribute to the sequelize query inLibraryItem.findAllExpandedWhere.Which issue is fixed?
Fixes #3883
In-depth Description
The bookSeries id is required for the
bookSeries.destroy()call here, without it, thedestory()call throws an exception since it doesn't have the id in order to construct the deletion query.Note: this only happens in batch quick match, which calls
findAllExpandedWhere()How have you tested this?
Batch quick match which crashed the server before now completes successfuly.