Fix Logger.fatal to ensure crash_logs.txt is written to #3919
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary
Logger.fatal
is called before the server closes on uncaught exceptions. When it gets called the log is written tocrash_logs.txt
.Logs weren't always being written to crash_logs.txt because
Logger.fatal
wasn't a promise andprocess.exit
was called before it was done.Which issue is fixed?
No issue
How have you tested this?
Threw some exceptions and ensured they were written to crash_logs.txt