Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Logger.fatal to ensure crash_logs.txt is written to #3919

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

advplyr
Copy link
Owner

@advplyr advplyr commented Jan 30, 2025

Brief summary

Logger.fatal is called before the server closes on uncaught exceptions. When it gets called the log is written to crash_logs.txt.

Logs weren't always being written to crash_logs.txt because Logger.fatal wasn't a promise and process.exit was called before it was done.

Which issue is fixed?

No issue

How have you tested this?

Threw some exceptions and ensured they were written to crash_logs.txt

@advplyr advplyr merged commit 344de94 into master Jan 30, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant