Add Mastercard 3DS card (take #2) #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcatanese
requested changes
Jan 25, 2024
There was a problem hiding this comment.
@sam-artuso Thanks for the PR. There is a small change required, we are then ready to merge. Next week we plan to release the new version.
Please remove the WIP tag when this is ready
At the time of branching the E2E tests on main were incorrect, we have now addressed it (#43 ).
sam-artuso
force-pushed
the
feat/add-mastercard-3ds-card-2
branch
2 times, most recently
from
11059ed
to
1b7c856
Compare
|
Rebased on top of master and squashed my commits. |
sam-artuso
force-pushed
the
feat/add-mastercard-3ds-card-2
branch
from
64bc17d
to
c8f36d3
Compare
sam-artuso
force-pushed
the
feat/add-mastercard-3ds-card-2
branch
from
1963f60
to
1dc3dd0
Compare
|
Looks great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: https://docs.adyen.com/development-resources/testing/test-card-numbers/#enrolled-in-3d-secure-2