addresses https://github.com/aeharding/ppg.report/issues/156 #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows certain User settings to be overridden via URL hash parameters. userSlice initialState will attempt to fetch values from URL hash, then fall back to localStorage or defaults. Example usage: ``` http://localhost:5173/29.352,-95.460#user-altitude=MSL&user-speed-unit=m/s&user-temperature-unit=%C2%B0C&user-height-unit=m&user-time-format=12-hour&user-distance-unit=km ```
aeharding
force-pushed
the
override-settings-with-url-params
branch
from
8dfcd6e to
3862123
Compare
|
Thanks so much for the contribution! This should now be deployed in v4.3.0 |
|
I was happy to help. I've met Caleb once, when he stopped by to visit Team Fly Halo in Salton Sea, and know a lot of people who use xcNav. I noticed you changed the || to ??, so I did a google search to learn why. Now, I'm one operator smarter. ;-) Thanks! p.s. I've shared this app with a bunch of people in the skydiving community, and have been thinking it might benefit from less-niche name and description. It's obviously useful for way, way more than just PPG. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows certain User settings to be overridden via URL hash parameters. userSlice initialState will attempt to fetch values from URL hash, then fall back to localStorage or defaults.
Example usage: