serializer code cleanup #68

orangishcat · 2025-02-05T06:39:59Z

Generalized the boolean case to return default object if true, and null otherwise
Code cleanup (removed unused imports, fixed warnings)

Signed-off-by: pythoncoder1234 <fdsnail2@gmail.com>

src/main/java/tanks/tankson/Compatibility.java

src/main/java/tanks/tankson/Serializer.java

ghostlypi · 2025-02-05T15:41:50Z

src/main/java/tanks/tankson/Serializer.java

+        Class<?> c = o.getClass();
+        A ann = null;
+        while (c != null && (ann = c.getAnnotation(a)) == null)
+            c = c.getSuperclass();


I think this is worse for readability.

src/main/java/tanks/tankson/Serializer.java

ghostlypi · 2025-02-05T15:49:00Z

src/main/java/tanks/Game.java

@@ -520,7 +519,6 @@ public static void initScript()
 		Drawing.initialize();
 		Panel.initialize();
 		Game.exitToTitle();
-		Compatibility.init();


Necessary, see later comments.

i couldn't find the later comment... is there anything wrong with a static initializer?

Signed-off-by: pythoncoder1234 <fdsnail2@gmail.com>

ghostlypi · 2025-02-05T19:25:16Z

Ok, from my end this is merge ready. I would definitely like to be involved in the merge, because I would like to do a manual merge of this.

orangishcat · 2025-05-28T16:19:02Z

ghostlypi has made his own pull request, so i will be closing this

serializer code cleanup

e0cf4a9

Signed-off-by: pythoncoder1234 <fdsnail2@gmail.com>