Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MetalLB v0.14.8 #492

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Update MetalLB v0.14.8 #492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/system/metallb/charts/metallb/Chart.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
dependencies:
- name: crds
repository: ""
version: 0.13.10
digest: sha256:afb2e9d5b709e7ded68c21f9d033a0a14a1232be270b0966e5ef2722575afc77
generated: "2023-05-31T15:40:56.282100173+02:00"
version: 0.14.8
- name: frr-k8s
repository: https://metallb.github.io/frr-k8s
version: 0.0.14
digest: sha256:8dff488902a5b504a491bbd1a9ab0983a877ff214e163ed74106c73c939a9aa3
generated: "2024-07-23T15:22:40.589621+03:00"
10 changes: 7 additions & 3 deletions packages/system/metallb/charts/metallb/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
apiVersion: v2
appVersion: v0.13.10
appVersion: v0.14.8
dependencies:
- condition: crds.enabled
name: crds
repository: ""
version: 0.13.10
version: 0.14.8
- condition: frrk8s.enabled
name: frr-k8s
repository: https://metallb.github.io/frr-k8s
version: 0.0.14
description: A network load-balancer implementation for Kubernetes using standard
routing protocols
home: https://metallb.universe.tf
Expand All @@ -14,4 +18,4 @@ name: metallb
sources:
- https://github.com/metallb/metallb
type: application
version: 0.13.10
version: 0.14.8
13 changes: 12 additions & 1 deletion packages/system/metallb/charts/metallb/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,15 @@ Kubernetes: `>= 1.19.0-0`
| Repository | Name | Version |
|------------|------|---------|
| | crds | 0.0.0 |
| https://metallb.github.io/frr-k8s | frr-k8s | 0.0.14 |

## Values

| Key | Type | Default | Description |
|-----|------|---------|-------------|
| controller.affinity | object | `{}` | |
| controller.enabled | bool | `true` | |
| controller.extraContainers | list | `[]` | |
| controller.image.pullPolicy | string | `nil` | |
| controller.image.repository | string | `"quay.io/metallb/controller"` | |
| controller.image.tag | string | `nil` | |
Expand Down Expand Up @@ -53,9 +55,14 @@ Kubernetes: `>= 1.19.0-0`
| controller.serviceAccount.create | bool | `true` | |
| controller.serviceAccount.name | string | `""` | |
| controller.strategy.type | string | `"RollingUpdate"` | |
| controller.tlsCipherSuites | string | `""` | |
| controller.tlsMinVersion | string | `"VersionTLS12"` | |
| controller.tolerations | list | `[]` | |
| crds.enabled | bool | `true` | |
| crds.validationFailurePolicy | string | `"Fail"` | |
| frrk8s.enabled | bool | `false` | |
| frrk8s.external | bool | `false` | |
| frrk8s.namespace | string | `""` | |
Comment on lines +63 to +65
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Based on the gathered information, I can now generate the final response:

FRR version upgrade requires attention

The FRR version has been updated to 9.1.0 in values.yaml, but the configuration templates in both speaker.yaml and controller.yaml still reference FRR version 8.0. Additionally, there's no explicit migration documentation for the FRR version upgrade. Please:

  • Update FRR version in configuration templates:
    • packages/system/metallb/charts/metallb/templates/speaker.yaml
    • packages/system/metallb/charts/metallb/charts/frr-k8s/templates/controller.yaml
  • Add migration notes to the chart's documentation detailing any breaking changes or required configuration updates for FRR 9.1.0
🔗 Analysis chain

Verify FRR version compatibility

The update to FRR 9.1.0 and the introduction of frr-k8s integration are significant changes. Please ensure:

  1. The new FRR version is compatible with existing configurations
  2. Migration documentation is available for users

Also applies to: 125-125

Let me gather more information about FRR version changes and migration documentation.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check for any version-specific FRR configurations
rg -A 5 "frr.*version|frr.*tag" --type yaml

Length of output: 10325

Script:

#!/bin/bash
# Check for FRR version changes in values.yaml and any migration docs
rg -A 5 "frr" packages/system/metallb/charts/metallb/values.yaml

# Check for migration or upgrade documentation
fd -e md | xargs rg -i "migrat|upgrad.*frr|frr.*upgrad|frr.*version"

Length of output: 7847

| fullnameOverride | string | `""` | |
| imagePullSecrets | list | `[]` | |
| loadBalancerClass | string | `""` | |
Expand Down Expand Up @@ -111,13 +118,15 @@ Kubernetes: `>= 1.19.0-0`
| speaker.affinity | object | `{}` | |
| speaker.enabled | bool | `true` | |
| speaker.excludeInterfaces.enabled | bool | `true` | |
| speaker.extraContainers | list | `[]` | |
| speaker.frr.enabled | bool | `true` | |
| speaker.frr.image.pullPolicy | string | `nil` | |
| speaker.frr.image.repository | string | `"quay.io/frrouting/frr"` | |
| speaker.frr.image.tag | string | `"8.4.2"` | |
| speaker.frr.image.tag | string | `"9.1.0"` | |
| speaker.frr.metricsPort | int | `7473` | |
| speaker.frr.resources | object | `{}` | |
| speaker.frrMetrics.resources | object | `{}` | |
| speaker.ignoreExcludeLB | bool | `false` | |
| speaker.image.pullPolicy | string | `nil` | |
| speaker.image.repository | string | `"quay.io/metallb/speaker"` | |
| speaker.image.tag | string | `nil` | |
Expand All @@ -130,6 +139,7 @@ Kubernetes: `>= 1.19.0-0`
| speaker.livenessProbe.timeoutSeconds | int | `1` | |
| speaker.logLevel | string | `"info"` | Speaker log level. Must be one of: `all`, `debug`, `info`, `warn`, `error` or `none` |
| speaker.memberlist.enabled | bool | `true` | |
| speaker.memberlist.mlBindAddrOverride | string | `""` | |
| speaker.memberlist.mlBindPort | int | `7946` | |
| speaker.memberlist.mlSecretKeyPath | string | `"/etc/ml_secret_key"` | |
| speaker.nodeSelector | object | `{}` | |
Expand All @@ -144,6 +154,7 @@ Kubernetes: `>= 1.19.0-0`
| speaker.reloader.resources | object | `{}` | |
| speaker.resources | object | `{}` | |
| speaker.runtimeClassName | string | `""` | |
| speaker.securityContext | object | `{}` | |
| speaker.serviceAccount.annotations | object | `{}` | |
| speaker.serviceAccount.create | bool | `true` | |
| speaker.serviceAccount.name | string | `""` | |
Expand Down
4 changes: 2 additions & 2 deletions packages/system/metallb/charts/metallb/charts/crds/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
apiVersion: v2
appVersion: v0.13.10
appVersion: v0.14.8
description: MetalLB CRDs
home: https://metallb.universe.tf
icon: https://metallb.universe.tf/images/logo/metallb-white.png
name: crds
sources:
- https://github.com/metallb/metallb
type: application
version: 0.13.10
version: 0.14.8
Loading