AER-2539 Attempt at improving suggestions from Bing map search #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The locations endpoint has a query part, but that doesn't really work as suggestions: it only returns results that are pretty much exactly what you're searching for, and something like 'edin' won't result anything. There is a autosuggest endpoint, but that one doesn't return geo information... So tying the 2 together, first the suggestion for sensible suggstions and then the locations endpoint to get geo information. Does mean more roundtrips, but there's a max of 10 results anyway.
BertScholten
changed the title
|
Ah |
JornC
approved these changes
Dec 1, 2023
search-service-bing-geocoder/src/main/java/nl/aerius/search/tasks/BingSearchService.java
Show resolved
Hide resolved
The name does not really fit in the locations-with-adress endpoint (when using it along with countryregion, you'll get just United Kingdom as a result...), so have to use the locations-with-query endpoint (which is the same, but has different query parameters, not the cleanest endpoint definition ever). Does mean more results are returned, so reduced number of max results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The locations endpoint has a query part, but that doesn't really work as suggestions: it only returns results that are pretty much exactly what you're searching for, and something like 'edin' won't result anything. There is a autosuggest endpoint, but that one doesn't return geo information... So tying the 2 together, first the suggestion for sensible suggstions and then the locations endpoint to get geo information. Does mean more roundtrips, but there's a max of 10 results anyway.