Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updoot to java 17 #49

Merged
merged 8 commits into from
Feb 7, 2024
Merged

Updoot to java 17 #49

merged 8 commits into from
Feb 7, 2024

Conversation

JornC
Copy link
Member

@JornC JornC commented Feb 7, 2024 •
edited
Loading

  • Updoot java compilation target to 17
  • Updoot github actions JDK_VERSIONs to 17
  • Updoot Dockerfile base image to a jdk 17 image

BertScholten
BertScholten approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@BertScholten BertScholten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one suggestion

docker/service/Dockerfile Outdated Show resolved Hide resolved
Hilbrand
Hilbrand requested changes Feb 7, 2024
View reviewed changes
pom.xml Show resolved Hide resolved
docker/service/Dockerfile Outdated Show resolved Hide resolved
Hilbrand
Hilbrand approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@Hilbrand Hilbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see if it still works when set to java 17.

@JornC JornC merged commit b6e081c into aerius:main Feb 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hilbrand Hilbrand Hilbrand approved these changes

@BertScholten BertScholten BertScholten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JornC @Hilbrand @BertScholten