Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client-2699 C Metrics #147

Closed
wants to merge 67 commits into from
Closed

Client-2699 C Metrics #147

wants to merge 67 commits into from

Conversation

shannonklaus
Copy link
Contributor

No description provided.

shannonklaus and others added 28 commits January 19, 2024 13:38
@shannonklaus
Add event loop info to file printing
81f9f4d
@BrianNichols
Merge branch 'stage' into CLIENT-2699_metrics
a823188
@shannonklaus
Update copyright year, fix timeout and error count in node_stats
dc50d0f
@shannonklaus
Change enum to macros for latency_type, add comments to cluster, and …
65a6f7e 
…rename error_rate_count to error_rate in node
@BrianNichols
Restore common submodule change.
8091d95
@shannonklaus
Update comments in metrics files, make timeout_count unsigned
a53adb2
@shannonklaus
Add metrics_writer type
b739b91
@shannonklaus
Add errors to enable and disable metrics
afd42f4
@shannonklaus
Comments and other small fixes
6775bc6
@shannonklaus
Fix warnings and errors
a0e3b62
@BrianNichols
Add as_string_builder_append_int64() and as_string_builder_append_uin…
8fe251a 
…t64().
@shannonklaus
Work on warnings
233a236
@shannonklaus
Fix warnings
fc7f322
@shannonklaus
Fixing bugs
a8f8bc0
@shannonklaus
Fixing more bugs
aa92db7
@shannonklaus
Add logging to help debug
126270f
@BrianNichols
Fix mac compiler errors/warnings.
a9c192b
@shannonklaus
Add code to check for trailing slash and add if missing based on oper…
2339eab 
…ating system
@shannonklaus
Free memory
3887ac2
@shannonklaus
Fix memory leak
7b9302f
@shannonklaus
Fix formatting
f57b4d2
@shannonklaus
PUshing latest
343eb10
@shannonklaus
Update cpu and mem
3d804c0
@BrianNichols
Call new as_event_connection_complete() when connection is complete i…
5b1ee26 
…n all 3 async frameworks.
@BrianNichols
Merge branch 'stage' into CLIENT-2699_metrics
2ef80a4
@shannonklaus
Add connection metrics
b7bedf3
@shannonklaus
Work on async and connection metrics
5339598
@shannonklaus
Update copyright year
455a1e1
BrianNichols and others added 9 commits February 15, 2024 14:06
@BrianNichols
Add as_metrics_policy_set_report_dir().
2306b3f 
Rename as_policy_metrics to as_metrics_policy.
@BrianNichols
Move metrics_writer implementation to it's own separate files.
b274d28 
Add as_metrics_writer_create() to be used when default metrics_writer implementation is needed.
Do not reserve nodes when function is always called from cluster tend thread.
Fix macos cpu/mem calculations.
@BrianNichols
Use cf_calloc to initialize as_metrics_writer struct. Ignore certain …
c85ba8f 
…Visual Studio warning messages.
@shannonklaus
Working on error cases
5d126c0
@shannonklaus
Fix for unit tests stopping unexpectedly
a20aa21
@BrianNichols
Do not exit(-1) in aerospike_test.c
c9ac449
@BrianNichols
Only reset error if a previous error was set.
287dc63
@BrianNichols
To be consistent revert back to older tend warning message format whe…
3d280ee 
…n calling snapshot listener.
@shannonklaus
Changes after error testing, disable metrics in unit tests
e8d11cb
@shannonklaus shannonklaus marked this pull request as ready for review February 21, 2024 21:48
@BrianNichols
Move latency bucket structs to as_latency.{c,h}
5deb361 
Move private node metrics to as_node.c
Temporarily enable metrics in test.
TODO: Comment out enable metrics when finished with new testing.
@BrianNichols
Port previous commit to windows.
b9bc5d0
@BrianNichols
Add metrics lock and run all metrics calls under this lock.
63d5315 
If a metrics file error occurs after the metrics file open succeeds in as_metrics_writer_enable(), close file and return error.
Destroy node metrics in as_node_destroy() and when metrics are disabled.
@BrianNichols
Comment out metrics enable in tests.
981701a
@BrianNichols
Add timeout_count and retry_count to aerospike_stats.
a12161d
@BrianNichols
Inline short cluster/node metrics functions.
1f0e5ef 
Call as_node_add_timeout() on timeout.
@BrianNichols
Call as_node_add_error() on errors other than timeout.
5563928 
Only add latency for commands that completed successfully,
In async, only set begin timestamp once at the beginning and measure time elapsed for connection creation and command completion from that time.
@BrianNichols
Call "as_cluster_add_retries(cluster, batch_nodes.size)" after batch_…
574c55c 
…nodes have been populated.
@BrianNichols
Pack as_cluster_stats and as_node for optimal size.
7192e98
@BrianNichols
Optimize setting async cmd latency_type.
37a374a
@BrianNichols
Do not increment node error count on record not found.
3f14ae6
@BrianNichols
Print socket address and port separated by a comma to be consistent w…
39a3795 
…ith the java client metrics output.
@BrianNichols
Initialize error_count, timeout_count before initializing node metrics.
f68b483
@BrianNichols
Calculate latency on AEROSPIKE_ERR_RECORD_NOT_FOUND too.
082a088
@BrianNichols
Increment retries when applicable in sync scans.
7e1a304 
Reserve nodes whenever writing cluster metrics.
@BrianNichols
Increment retries when applicable in sync queries.
b3c2289
@BrianNichols
Do not pass in as_error to as_cluster_remove_nodes() because it never…
ced01be 
… needs to return an error.
@BrianNichols
Remove <p> as doxygen does not use it.
901ded2 
FIx report_dir default doc.
@BrianNichols
Remove upgrade log
8a647af
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrianNichols BrianNichols Awaiting requested review from BrianNichols

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shannonklaus @BrianNichols