This repository was archived by the owner on Nov 17, 2025. It is now read-only.
Do not always remap storage in fgraph_to_python#1291
Merged
brandonwillard merged 3 commits intoaesara-devs:mainfrom Nov 11, 2022
Merged
Do not always remap storage in fgraph_to_python#1291brandonwillard merged 3 commits intoaesara-devs:mainfrom
fgraph_to_python#1291brandonwillard merged 3 commits intoaesara-devs:mainfrom
Conversation
brandonwillard
added
bug
brandonwillard
force-pushed
the
fix-Numba-composite-storage
branch
from
2b621bc to
4a6ecdf
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1291 +/- ##
==========================================
+ Coverage 74.10% 74.12% +0.01%
==========================================
Files 174 174
Lines 48624 48654 +30
Branches 10351 10353 +2
==========================================
+ Hits 36035 36064 +29
+ Misses 10301 10300 -1
- Partials 2288 2290 +2
|
brandonwillard
force-pushed
the
fix-Numba-composite-storage
branch
from
4a6ecdf to
3415ab0
Compare
brandonwillard
changed the title
Compositesfgraph_to_python
brandonwillard
force-pushed
the
fix-Numba-composite-storage
branch
from
3415ab0 to
f24fac6
Compare
brandonwillard
changed the title
fgraph_to_pythonfgraph_to_python
brandonwillard
force-pushed
the
fix-Numba-composite-storage
branch
from
f24fac6 to
d56381e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue resulting from re-mapped storage cells in
fgraph_to_python. The issue was discovered in #1289 viaTestOpFromGraph.test_grad.Basic
OpFromGraphsupport for Numba is added in this PR as well.