Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Dockerfile and docker-compose for web-only debugging/environment #112

Closed
wants to merge 2 commits into from
Closed

Added Dockerfile and docker-compose for web-only debugging/environment #112

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d42a710
Added Dockerfile and docker-compose for web-only debugging/environment
AnushthanS Sep 16, 2024
68782d9
minor dockerfile change
AnushthanS Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
FROM node:22
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node:latest pls

Copy link

@colemvnio colemvnio Oct 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would tend to favor the fixed version as well to promote predictability, backwards compatibility and security. Using the latest tag would promote builds to non-lts versions which could introduce unwanted/unknown issues.

When updating versions, then the Dockerfile should simply be updated as well.


RUN npm i -g pnpm

RUN curl https://sh.rustup.rs -sSf | sh -s -- -y
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the command be curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh

https://www.rust-lang.org/tools/install

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That command initiated a cli based interactive installer. I tried a bunch of flags and ended up with this as the simplest method.


ENV PATH="/root/.cargo/bin:$PATH"

WORKDIR /app

COPY . .

RUN pnpm install

EXPOSE 1420

CMD ["pnpm", "run", "dev", "--host"]
12 changes: 12 additions & 0 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
services:
wealthfolio-app:
build:
context: .
dockerfile: Dockerfile
ports:
- "1420:1420"
volumes:
- ./src:/app/src
- ./public:/app/public
environment:
- PATH=/root/.cargo/bin:${PATH}