Validate jwt: test cases fix (#322)

* fix: did & added validation on expiresAt * fix: did & added validation on expiresAt * fix: lib version upgrade * fix: linter issue * fix: merge conditions * fix: linter error * fix: linter error * fix: corrected changelog date * fix: condition added to handle undefined exp * fix: condition added to handle undefined exp * fix: error codes and messages --------- Co-authored-by: Mritunjay Kumar <mritunjaykumar@Mac-C02G429HMD6R.local>
affinidi · Aug 24, 2023 · 2cdc8f6 · 2cdc8f6
1 parent c5e3b6d
commit 2cdc8f6
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/common-libs/common/test/unit/Affinity.test.ts b/common-libs/common/test/unit/Affinity.test.ts
@@ -298,7 +298,7 @@ describe('Affinity', () => {
     }
 
     expect(expiredTokenError).to.be.not.undefined
-    expect(expiredTokenError.message).to.be.equal('Token expired')
+    expect(expiredTokenError.message).to.be.equal('Token expired or invalid expiration')
   })
 
   it('#validateJWT (When initial token do not match)', async () => {

diff --git a/common-libs/tools-common/src/SdkError.ts b/common-libs/tools-common/src/SdkError.ts
@@ -178,7 +178,7 @@ export const commonErrors = {
   },
   'COR-19': {
     type: 'OperationError',
-    message: 'Token expired',
+    message: 'Token expired or invalid expiration',
     httpStatusCode: 400,
   },
   'COR-20': {

diff --git a/sdk/core/src/services/HolderService.ts b/sdk/core/src/services/HolderService.ts
@@ -171,7 +171,7 @@ export default class HolderService {
     try {
       await this._affinityService.validateJWT(credentialShareResponseToken, credentialShareRequestToken, didDocument)
     } catch (error) {
-      if (error.message === 'Token expired') {
+      if (error.message === 'Token expired or invalid expiration') {
         throw new SdkErrorFromCode('COR-19')
       }
 
@@ -242,14 +242,14 @@ export default class HolderService {
     }
 
     if (payload.exp < Date.now()) {
-      throw new Error('Token expired')
+      throw new Error('Token expired or invalid expiration')
     }
   }
   async verifyCredentialOfferRequest(credentialOfferRequestToken: string) {
     try {
       await this._affinityService.validateJWT(credentialOfferRequestToken)
     } catch (error) {
-      if (error.message === 'Token expired') {
+      if (error.message === 'Token expired or invalid expiration') {
         return { isValid: false, errorCode: 'COR-19', error: error.message }
       }
 

diff --git a/sdk/core/test/integration/NetworkMember.test.ts b/sdk/core/test/integration/NetworkMember.test.ts
@@ -703,7 +703,7 @@ describe('CommonNetworkMember', () => {
     const { code, httpStatusCode, message } = responseError
 
     expect(code).to.equal('COR-19')
-    expect(message).to.equal('Token expired')
+    expect(message).to.equal('Token expired or invalid expiration')
     expect(httpStatusCode).to.equal(400)
   })