feat(FTL-16871): integrate with redirect flow #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maindotdev
previously approved these changes
Oct 7, 2024
andrew-affinidi
previously approved these changes
Oct 7, 2024
rbrazhnyk
dismissed stale reviews from andrew-affinidi and maindotdev
via
7440ae6
maindotdev
approved these changes
Oct 8, 2024
Comment on lines
+96
to
+98
| function getShareLink(jwt: string, clientId: string) { | ||
| return VaultUtils.buildShareLink(jwt, clientId); | ||
| } |
There was a problem hiding this comment.
No need for a separate function
|
|
||
| const IotaRedirectFlowCallbackPage = dynamic( | ||
| () => import("../components/iota/RedirectFlowCallbackPage"), | ||
| { ssr: false }, |
There was a problem hiding this comment.
There should be no need to make the redirect pages components and disable SSR.
|
|
||
| const IotaRedirectFlowPage = dynamic( | ||
| () => import("../components/iota/RedirectFlowPage"), | ||
| { ssr: false }, |
There was a problem hiding this comment.
There should be no need to make the redirect pages components and disable SSR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.