Skip to content
This repository has been archived by the owner on Sep 3, 2023. It is now read-only.

Fix dialogWrapContent for customView #1853 #2040

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

haluzpav
Copy link

@haluzpav haluzpav commented Dec 9, 2020

Fixes dialogWrapContent option of customView #1853.

Previously DialogContentLayout always passed EXACTLY as width spec, which canceled out WRAP_CONTENT width of a custom view. Now it will pass AT_MOST which allows the custom view to actually wrap its content.

Mauker1 and others added 24 commits February 17, 2020 19:30
Updating documentation to show that you can also set the maxDate parameter.
Set hint on TextInputLayout instead of EditText so that it animates properly when you start typing.

From documentation:
* The hint should be set on the TextInputLayout, rather than the EditText. If a hint is specified
 * on the child EditText in XML, the TextInputLayout might still work correctly; TextInputLayout
 * will use the EditText's hint as its floating label. However, future calls to modify the hint will
 * not update TextInputLayout's hint.
…atically (afollestad#1972)

* Change RadioButton's colors programmatically

* Update sample to demonstrate changing RadioButton's colors programmatically
@XiXiongMaoXiong
Copy link

XiXiongMaoXiong commented May 5, 2021

Fixes dialogWrapContent option of customView #1853.

Previously DialogContentLayout always passed EXACTLY as width spec, which canceled out WRAP_CONTENT width of a custom view. Now it will pass AT_MOST which allows the custom view to actually wrap its content.

I just can't fucking believe that the dev didn't bothered his bum to merge this, yet!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants