This repository has been archived by the owner on Sep 3, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Implemented #2018: Added support for multi-lined input fields of a given line count #2042
Open
gobrien37
wants to merge
25
commits into
afollestad:main
Choose a base branch
from
gobrien37:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating documentation to show that you can also set the maxDate parameter.
Resolves #1922 and #1841
Set hint on TextInputLayout instead of EditText so that it animates properly when you start typing. From documentation: * The hint should be set on the TextInputLayout, rather than the EditText. If a hint is specified * on the child EditText in XML, the TextInputLayout might still work correctly; TextInputLayout * will use the EditText's hint as its floating label. However, future calls to modify the hint will * not update TextInputLayout's hint.
…atically (afollestad#1972) * Change RadioButton's colors programmatically * Update sample to demonstrate changing RadioButton's colors programmatically
Updated version
… specified line height
@afollestad Could you please review and merge this PR if it looks okay? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per issue #2018, It is now possible to have input dialogs that wrap to additional lines. The allowed number of lines that can be displayed at once is declared in the maxLines parameter of input. Any lines beyond maxLines can still be scrolled. Multi-line input fields require the TYPE_TEXT_FLAG_MULTI_LINE inputType to work.
An additional sample, input_multiline, has been created to demonstrate this implementation.