Added unit test for bounding sphere updates on text geometry changes #5312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much for this. I just merged the changes and moved the dependency back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
As described in #5311 the bounding sphere of the text geometry wasn't being recomputed when the geometry changed. This could lead to incorrect frustum culling. The actual fix should be inside
three-bmfont-text, but this PR serves to both bump that dependency and introducing a unit test to avoid regressions.Marked draft as the dependency now points to a fork until dmarcos/three-bmfont-text#2 is merged (or an alternative fix)
Changes proposed:
three-bmfont-textversion in package.json to one including a fix