Skip to content

Add new async_process method #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 19, 2025
Merged

Add new async_process method #696

merged 4 commits into from
Apr 19, 2025

Conversation

kumaranvpl
Copy link
Collaborator

Description

Fixes #690

Type of change

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • I have included code examples to illustrate the modifications

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new asynchronous processing method to improve how async responses are handled during workflow operations. Key changes include:

  • Replacing the synchronous run method with an asynchronous variant in tests.
  • Introducing the async_process method in the base module to handle async responses.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
tests/runtime/ag2/test_autogen.py Updated test to use asynchronous run method and process async response.
fastagency/base.py Added async_process method to asynchronously handle response events.
Comments suppressed due to low confidence (1)

tests/runtime/ag2/test_autogen.py:245

  • [nitpick] Consider renaming 'a_run' to a more descriptive name such as 'run_async' to better indicate its asynchronous behavior.
response = student_agent.a_run(

@kumaranvpl kumaranvpl added this pull request to the merge queue Apr 19, 2025
Merged via the queue into main with commit 182f408 Apr 19, 2025
24 checks passed
@kumaranvpl kumaranvpl deleted the fix-arun branch April 19, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Displaying agent messages in Mesop when using agent.a_run
2 participants