Add api for nats message scheduling #2640
Merged
+213
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
dependencies
Lancetnik
requested changes
Nov 3, 2025
Member
Lancetnik
left a comment
Lancetnik
left a comment
There was a problem hiding this comment.
Can you please add a little documentation section about new section?
faststream/nats/schemas/schedule.py
Outdated
|
|
||
| __slots__ = ("target", "time") | ||
|
|
||
| def __init__(self, time: datetime | str, target: str, /) -> None: |
faststream/nats/schemas/schedule.py
Outdated
| from faststream._internal.proto import NameRequired | ||
|
|
||
|
|
||
| class Schedule(NameRequired): |
Member
There was a problem hiding this comment.
We shouldn't inherit this class here. You can make a regular dataclass
tests/brokers/nats/test_publish.py
Outdated
| assert await response.decode() == "Hi!", response | ||
|
|
||
| @pytest.mark.asyncio() | ||
| async def test_publish_with_schedule( |
Member
There was a problem hiding this comment.
Please, move this test out of class to regular test function
tests/brokers/nats/test_publish.py
Outdated
|
|
||
| assert await response.decode() == "Hi!", response | ||
|
|
||
| @pytest.mark.asyncio() |
Member
There was a problem hiding this comment.
Seems like we need to add connected and nats markers here
github-actions
bot
added
the
documentation
github-actions
bot
added
the
github_actions
Lancetnik
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR provide api for scheduling messages via Nats JetStream
Checklist
just lintshows no errors)just test-coveragejust static-analysis