Fix root password detection (#1201)

Properly detect whether the root password is set.
agama-project · May 13, 2024 · 4be7618 · 4be7618
2 parents d2096d1 + 6cc5a78
commit 4be7618
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/web/src/client/users.js b/web/src/client/users.js
@@ -84,7 +84,7 @@ class UsersBaseClient {
       return false;
     }
     const config = await response.json();
-    return config.password !== "";
+    return config.password;
   }
 
   /**

diff --git a/web/src/client/users.test.js b/web/src/client/users.test.js
@@ -79,7 +79,7 @@ describe("#getUser", () => {
 describe("#isRootPasswordSet", () => {
   describe("when the root password is set", () => {
     beforeEach(() => {
-      mockJsonFn.mockResolvedValue({ password: "12345", sshkey: "" });
+      mockJsonFn.mockResolvedValue({ password: true, sshkey: "" });
     });
 
     it("returns true", async () => {
@@ -90,7 +90,7 @@ describe("#isRootPasswordSet", () => {
 
   describe("when the root password is not set", () => {
     beforeEach(() => {
-      mockJsonFn.mockResolvedValue({ password: "", sshkey: "" });
+      mockJsonFn.mockResolvedValue({ password: false, sshkey: "" });
     });
 
     it("returns false", async () => {