Skip to content

Commit

Permalink
Fix build (#1623)
Browse files Browse the repository at this point in the history
`agama` and `agama-web-ui` are failing to build. This branch includes a
set of fixes.

- **fix(web): fix wrong reference to HTTPClient**
- **fix(rust): fix format of profile.schema.json**
- **fix(web): add @testing-library/dom**
- **fix(web): disable type checking for ts-loader**

We need to investigate especially the `ts-loader` problem, because it
did not happen neither on CI
nor in our development machines.
  • Loading branch information
imobachgs authored Sep 20, 2024
2 parents 484fa9c + 5b6c9de commit 4d0d973
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 20 deletions.
2 changes: 1 addition & 1 deletion rust/agama-lib/share/profile.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@
"tkip",
"ccmp"
]
},
}
},
"pairwiseAlgorithms": {
"type": "array",
Expand Down
22 changes: 5 additions & 17 deletions web/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions web/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
"@pmmmwh/react-refresh-webpack-plugin": "^0.5.10",
"@svgr/plugin-jsx": "^8.1.0",
"@svgr/webpack": "^8.1.0",
"@testing-library/dom": "^10.4.0",
"@testing-library/jest-dom": "^6.2.0",
"@testing-library/react": "^16.0.1",
"@testing-library/user-event": "^14.5.1",
Expand Down
2 changes: 1 addition & 1 deletion web/src/client/storage.js
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ const dbusBasename = (path) => path.split("/").slice(-1)[0];
*/
class ProposalManager {
/**
* @param {import("./http").HTTPClien} client
* @param {import("./http").HTTPClient} client
*/
constructor(client) {
this.client = client;
Expand Down
3 changes: 2 additions & 1 deletion web/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,8 @@ module.exports = {
getCustomTransformers: () => ({
before: [development && ReactRefreshTypeScript()].filter(Boolean),
}),
transpileOnly: development,
// FIXME: temporarily disable the type checking.
transpileOnly: true,
},
},
],
Expand Down

0 comments on commit 4d0d973

Please sign in to comment.