-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storage): API support for storage settings #1471
Merged
joseivanlopez
merged 8 commits into
agama-project:master
from
joseivanlopez:api-storage-settings
Aug 27, 2024
Merged
feat(storage): API support for storage settings #1471
joseivanlopez
merged 8 commits into
agama-project:master
from
joseivanlopez:api-storage-settings
Aug 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseivanlopez
force-pushed
the
api-storage-settings
branch
from
July 16, 2024 15:24
f30131d
to
12320be
Compare
joseivanlopez
changed the title
feat(storage): basic support for storage settings
feat(storage): API support for storage settings
Jul 17, 2024
joseivanlopez
force-pushed
the
api-storage-settings
branch
from
August 21, 2024 13:18
12320be
to
f3b0865
Compare
joseivanlopez
force-pushed
the
api-storage-settings
branch
6 times, most recently
from
August 26, 2024 12:01
22c337a
to
9b6a92b
Compare
joseivanlopez
force-pushed
the
api-storage-settings
branch
from
August 27, 2024 10:01
eccb6b0
to
d97a4ec
Compare
joseivanlopez
force-pushed
the
api-storage-settings
branch
from
August 27, 2024 10:26
d97a4ec
to
f0b28ce
Compare
joseivanlopez
force-pushed
the
api-storage-settings
branch
from
August 27, 2024 14:48
f0b28ce
to
bebd554
Compare
joseivanlopez
force-pushed
the
api-storage-settings
branch
from
August 27, 2024 14:49
bebd554
to
3e1c2ee
Compare
ancorgs
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approved after changelog fix.
Merged
imobachgs
added a commit
that referenced
this pull request
Sep 20, 2024
Prepare for releasing Agama 10· * #1263 * #1330 * #1407 * #1408 * #1410 * #1411 * #1412 * #1416 * #1417 * #1419 * #1420 * #1421 * #1422 * #1423 * #1424 * #1425 * #1428 * #1429 * #1430 * #1431 * #1432 * #1433 * #1436 * #1437 * #1438 * #1439 * #1440 * #1441 * #1443 * #1444 * #1445 * #1449 * #1450 * #1451 * #1452 * #1453 * #1454 * #1455 * #1456 * #1457 * #1459 * #1460 * #1462 * #1464 * #1465 * #1466 * #1467 * #1468 * #1469 * #1470 * #1471 * #1472 * #1473 * #1475 * #1476 * #1477 * #1478 * #1479 * #1480 * #1481 * #1482 * #1483 * #1484 * #1485 * #1486 * #1487 * #1488 * #1489 * #1491 * #1492 * #1493 * #1494 * #1496 * #1497 * #1498 * #1499 * #1500 * #1501 * #1502 * #1503 * #1504 * #1505 * #1506 * #1507 * #1508 * #1510 * #1511 * #1512 * #1513 * #1514 * #1515 * #1516 * #1517 * #1518 * #1519 * #1520 * #1522 * #1523 * #1524 * #1525 * #1526 * #1527 * #1528 * #1529 * #1530 * #1531 * #1532 * #1533 * #1534 * #1535 * #1536 * #1537 * #1540 * #1541 * #1543 * #1544 * #1545 * #1546 * #1547 * #1548 * #1549 * #1550 * #1552 * #1553 * #1554 * #1555 * #1556 * #1557 * #1558 * #1559 * #1560 * #1562 * #1563 * #1565 * #1566 * #1567 * #1568 * #1569 * #1570 * #1571 * #1572 * #1573 * #1574 * #1575 * #1576 * #1577 * #1578 * #1579 * #1580 * #1581 * #1583 * #1584 * #1585 * #1586 * #1587 * #1588 * #1589 * #1590 * #1591 * #1592 * #1593 * #1596 * #1597 * #1598 * #1600 * #1602 * #1605 * #1606 * #1607 * #1608 * #1610 * #1611 * #1612 * #1613 * #1614 * #1619 * #1620 * #1621
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A JSON schema for the storage config is defined by #1455. This PR adds support to the D-Bus API to allow setting a JSON config following that new JSON schema:
#SetConfig
For now, the
#SetConfig
D-Bus method admits 3 different JSON formats for the given JSON config:The plan is to make
#SetConfig
and#GetConfig
only to work with a storage config or a legacy AutoYaST config. The guided config is still accepted by#SetConfig
because the new storage config does not offer all the options offered by guided config yet.In the future, the guided config will be neither accepted nor reported by
#SetConfig
and#GetConfig
respectively. Nevertheless, a D-Bus method accepting the guided config will still be offered as a simplification of the storage settings to make easier to work with the use cases supported by the web UI.#GetConfig
Currently,
#GetConfig
reports different config formats depending on how the proposal was calculated:#SetConfig
was called with guided config: reports guided config (extended with mandatory volumes, etc).#SetConfig
was called with storage config: reports exactly the given storage config.#SetConfig
was called with legacy AutoYaST config: reports exactly the given legacy AutoYaST config.Storage1.Proposal#Calculate
was called: reports the guided config (extended with mandatory volumes, etc).In the future,
#GetConfig
will only report either the storage config or the legacy AutoYaST config.