feature(storage): config support for current size #1617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseivanlopez
force-pushed
the
storage-size-current
branch
5 times, most recently
from
71b0df3
to
d3ee397
Compare
joseivanlopez
force-pushed
the
storage-size-current
branch
5 times, most recently
from
4f06d2f
to
db9d97c
Compare
- Do not remove configs if a search is not found. - Introduce ConfigSolver class. - Extend ConfigChecker to generate search issues.
joseivanlopez
force-pushed
the
storage-size-current
branch
from
db9d97c
to
524833b
Compare
- New config solver for sizes (current, defaults, etc). - Move logic related to fallback sizes to ConfigBuilder.
joseivanlopez
force-pushed
the
storage-size-current
branch
from
1e4f1eb
to
aa00a4f
Compare
ancorgs
added a commit
that referenced
this pull request
Sep 24, 2024
#1617 introduced some changes on the acceptable values for sizes and how they are managed. To be precise, it affects the special values like "default" (that is not longer considered an option) and "current". It also changes the behavior when the size is omitted for a partition or logical volume. The current PR updates the documentation to reflect the changes introduced at the mentioned pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to the storage config for resizing a partition using its current size as minimum or maximim limit, see auto_storage.md document.
For growing a partition as much as possible:
{ "partitions": [ { "search": "/dev/vda1", "size": { "min": "current" } } ] }For shrinking a partition as much as possible:
{ "partitions": [ { "search": "/dev/vda1", "size": { "min": 0, "max": "current" } } ] }For omittied size, the default size indicated by the product is used for a new partition. If the partition already exists (has a search), then the current device size is used as default (i.e., the device is not resized at all).