Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: add config support for TPM FDE #1681

Merged

Conversation

joseivanlopez
Copy link
Contributor

@joseivanlopez joseivanlopez commented Oct 17, 2024

Extend the storage schema to allow selecting TPM FDE as encryption method and adapt config checker to complain if TPM FDE is selected but is not available.

- Do not pre-assign default values, otherwise it is impossible to
  know whether such values have to be solved.
@coveralls
Copy link

coveralls commented Oct 18, 2024

Pull Request Test Coverage Report for Build 11457735133

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 25 of 26 (96.15%) changed or added relevant lines in 5 files are covered.
  • 66 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.2%) to 71.629%

Changes Missing Coverage Covered Lines Changed/Added Lines %
service/lib/agama/storage/config_conversions/to_json_conversions.rb 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
rust/agama-lib/src/install_settings.rs 2 0.0%
service/lib/agama/storage/config_conversions/to_json_conversions.rb 4 0.0%
rust/agama-lib/src/lib.rs 6 31.25%
rust/agama-lib/src/store.rs 17 0.0%
rust/agama-server/src/web.rs 37 0.0%
Totals Coverage Status
Change from base Build 11403686461: -0.2%
Covered Lines: 16873
Relevant Lines: 23556

💛 - Coveralls

@joseivanlopez joseivanlopez marked this pull request as ready for review October 22, 2024 09:54
@joseivanlopez joseivanlopez changed the title storage: add missing config properties storage: add config support for TPM FDE Oct 22, 2024
Copy link
Contributor

@ancorgs ancorgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joseivanlopez joseivanlopez merged commit eeaf714 into agama-project:master Oct 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants