Document the Jsonnet example #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvidner
reviewed
Jul 10, 2023
| // This is a Jsonnet file. Please, check https://jsonnet.org/ for more | ||
| // information about the language. | ||
|
|
||
| // The hw.libsonnet file contains hardware information from the "lshw" tool. |
There was a problem hiding this comment.
On Leap 15.4 at least, lshw.rpm or jsonnet.rpm do not contain a hw.libsonnet file. Where do I find it or how do I know what API it provides?
mvidner
reviewed
Jul 10, 2023
Co-authored-by: Martin Vidner <mvidner@suse.cz>
mvidner
approved these changes
Jul 10, 2023
lslezak
reviewed
Jul 10, 2023
| // https://github.com/openSUSE/agama/blob/master/rust/agama-lib/share/profile.schema.json | ||
|
|
||
| // The "hw.libsonnet" file contains hardware information of the storage devices | ||
| // from the "lshw" tool. It is generated by running as root: |
There was a problem hiding this comment.
I think the most important information is that it is explicitly run by Agama itself, there is no magic for that.
https://github.com/openSUSE/agama/blob/b4bf25fdffd46735800a8396f1715fffe181e1db/rust/agama-lib/src/profile.rs#L128
There was a problem hiding this comment.
I merged too soon. I opened #655.
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some comments to the Jsonnet-based example.