Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ new ] IO buffering, and loops #2367
[ new ] IO buffering, and loops #2367
Changes from all commits
da96a88
a8be231
1bf539e
a885335
1cf6f2c
513f564
cd7200f
1138237
e200afc
9ae32c5
4f4bbe0
48dfa71
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gallais: Are there plans to use
IO.Primitive
for something else?(Otherwise, why the deprecation?)
(Maybe the end user want to import the "top-level" modules rather than
Core
modules.)Question came up when updating the Agda testsuite to latest std-lib:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No plans on my end. It was a cleanup because having
IO.Primitive
sit "above" other primitive-bindingmodules like
IO.Primitive.Finite
seemed at odds with our current practice of theX.Y
module beinga partial re-export of
X.Y.Z
ones.It's named
Core
because we don't expect anyone to be importing it (or any of theIO.Primitive
modulesfor that matter) as we provide a high-level
IO
interface.