-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRY] refactor #2479 #2485
[DRY] refactor #2479 #2485
Conversation
If something's only just been introduced, and hasn't actually been released yet (2.2 is still "in development"), it definitely doesn't need a deprecation, it can just be removed |
Yes, that was my original thinking, but as @omelkonian 's contribution was based on existing external libraries, it occurred to me that there are pre-existing client uses of these 'new' definitions... so such uses perhaps 'deserve' the deprecation warning? But if @omelkonian were to refactor those external libraries in the meantime... it would definitely make sense to streamline this PR even further! |
@jamesmckinna There is no need to care about such deprecation warnings, since these are not 'external libraries' per se; one is my personal prelude and another is a verification project that is not meant to be imported at all. |
It occurs to me that corresponding lemmas ought to be provable in the |
Strong agree: the kind of entropy you build in if you're that strict reduces development to a crawl. |
This refactors the (very!) recent additions to
Data.List.Membership.Propositional.Properties
for nested lists in favour of delegation to existing functionality.NB:
map∷-decomp
is possibly redundant/excessive, given how recently introduced was that name/definitionmap∷⁻
is likewise arguably redundant, in favour of inlining its definition, but useful perhaps for its type which enforces thevariable = complex
refinement of our existing heuristic for writing library rewrite lemmas in the formcomplex = simpler
I'd be happy either way if this were merged or not, but it struck me as a useful reminder to be careful (and: more careful than I had been) about reviewing contributions against possible DRY violations.