Split Yoneda embedding into separate module and rename helper functions#1299
Open
dancewithheart wants to merge 3 commits intoagda:masterfrom
Open
Split Yoneda embedding into separate module and rename helper functions#1299dancewithheart wants to merge 3 commits intoagda:masterfrom
dancewithheart wants to merge 3 commits intoagda:masterfrom
Conversation
Collaborator
|
What's the impetus for splitting it into two files? |
Author
|
I treated the split as part of the cleanup: the file mixes the core Yoneda lemma The idea was simply to separate those. I re-exported from If the extra file is not desirable, I'm happy to keep everything in one file I also thought it might be useful to import the lemma without the embedding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split the Yoneda embedding definitions out of
Cubical.Categories.Yonedainto a separate moduleCubical.Categories.Yoneda.Embedding.The main names are re-exported from
Cubical.Categories.Yonedato preserve the existing interface.
Also rename helper functions:
yo-yo-yo→yonedaToElementno-no-no→elementToYonedaPartially address #1285.