feat: import shared design tokens from design-system#268
Merged
Conversation
Use object-form source {"source": "url", "url": "..."} instead of bare
URL strings, and remove unrecognized "requires"/"core" keys that cause
schema validation errors when loading the marketplace.
Replace inline token definitions with @import from the shared design-system at the monorepo root. Keeps brand personality docs as comments for reference.
Fonts were previously loaded via CSS @import in tokens.css which is render-blocking. Move to HTML <link> tag for parallel loading.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to align the site styling with the shared agent-sh/design-system by replacing the large in-repo tokens.css with imports, and moves Google Fonts loading from CSS @import to an HTML <link>.
Changes:
- Add a Google Fonts stylesheet
<link>insite/index.html. - Replace the previous inlined design tokens/reset CSS with
@importstatements intended to pull from a shared design-system. - Update
.claude-plugin/marketplace.jsonplugin entries (schema/fields changed).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| site/index.html | Adds Google Fonts stylesheet link in the document head. |
| site/assets/css/tokens.css | Removes local tokens/reset and replaces with imports from a supposed shared design-system. |
| .claude-plugin/marketplace.json | Changes plugin entry structure (notably source) and removes dependency metadata fields. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…hanges - Vendor tokens.css and base.css into site/assets/css/design-system/ so they resolve correctly in standalone builds - Fix @import paths to use local ./design-system/ instead of workspace-relative - Revert marketplace.json changes that were accidentally included
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<link>tag to HTML head (was previously loaded via CSS @import which is render-blocking)Context
Part of agent-sh/agent-sh.dev#1 - unified design system across all agent-sh sites.
The shared tokens now live in agent-sh/design-system.
Test Plan