fix: tune Java/Kotlin patterns to reduce false positives#22
Merged
Conversation
Tested against 6 real-world repos (1955 files total): - spring-petclinic, spring-authorization-server (Java corporate) - nowinandroid, Pokedex (Kotlin mobile) - gson (Java lib), Exposed (Kotlin lib) Changes: - java_suppress_warnings: narrow to unchecked|rawtypes|all|deprecation (was matching serial, ThreadLocalUsage, PMD.* etc.) - kotlin_suppress_annotation: narrow to UNCHECKED_CAST|DEPRECATION|unused (was matching MagicNumber, ForbiddenComment, UnstableApiUsage etc.) - java_raw_type: add \b word boundary to prevent matching JWKSet, ResultSet, SourceSet, BitSet as raw types - kotlin_println_debugging: exclude *.gradle.kts, *.gradle, snippets/ (println in Gradle scripts is standard, not debug output) False positive reduction: 544 -> 286 matches (-47%) across test repos. All remaining matches are true positives.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tested the new Java/Kotlin patterns against 6 real-world repos (1955 files):
Patterns tuned
java_suppress_warnings: Narrowed tounchecked|rawtypes|all|deprecationonly (was matchingserial,ThreadLocalUsage,PMD.*)kotlin_suppress_annotation: Narrowed toUNCHECKED_CAST|DEPRECATION|unusedonly (was matchingMagicNumber,ForbiddenComment,UnstableApiUsage)java_raw_type: Added\bword boundary (was false-positive onJWKSet,ResultSet,SourceSet,BitSet)kotlin_println_debugging: Excluded*.gradle.kts,*.gradle,**/snippets/**(Gradle println is standard output, not debugging)Results
Total false positives reduced: 544 -> 286 matches (-47%). All remaining matches are true positives.
Test plan