feat(go): add 6 patterns from false negative hunt#26
Merged
Conversation
…obra, zap New patterns found by team of 4 agents scanning real-world Go repos: - go_unchecked_type_assertion [high] - .(Type) without comma-ok panics - go_panic_recoverable [high] - panic() for recoverable errors - go_error_string_capitalized [low] - Go convention: lowercase errors - go_defer_close_no_error [low] - defer Close() hides cleanup failures - go_weak_random [medium] - math/rand for security-sensitive ops - go_unused_append [critical] - append() result not assigned (always a bug) Total Go patterns: 15. Tested against gin, echo, cobra, zap. 62 new true detections, 0 false positives in new patterns.
avifenesh
force-pushed
the
feat/go-false-negative-patterns
branch
from
55ba0fb to
0a01ca1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
6 new Go patterns discovered by team of 4 agents scanning gin, echo, cobra, zap:
go_unchecked_type_assertiongo_panic_recoverablego_error_string_capitalizedgo_defer_close_no_errorgo_weak_randomgo_unused_appendTotal Go patterns: 15. 62 new true detections, 0 false positives.
Sources: Uber Go Style Guide, Go Code Review Comments, staticcheck, golangci-lint.
Test Plan