feat: auto-detect auth walls after successful authentication#63
Merged
feat: auto-detect auth walls after successful authentication#63
Conversation
Three-heuristic AND-logic detection: 1. Domain cookies exist for target URL 2. Current page URL matches auth patterns 3. DOM contains login elements or text Short-circuits on first failing heuristic for efficiency.
When navigating via goto, automatically detect auth walls using the three-heuristic module. On detection: close headless browser, relaunch headed for interactive checkpoint, return post-auth snapshot. Opt out with --no-auth-wall-detect flag.
Unit tests for the detection module with 14 test cases covering: - Three-heuristic AND logic (each can fail independently) - Cookie domain matching (parent + exact) - Real-world providers (Google, Microsoft) - Error handling for page.$ and textContent failures - Exported constants validation Integration tests verifying web-ctl.js source-level integration.
…add tests - Parallelize DOM selector checks with Promise.allSettled (perf) - Limit textContent to first 5000 chars (perf/memory) - Cap checkpoint timeout at 3600s max (security) - Add tests for invalid URL and cookie read error paths - Add case-insensitive URL matching test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/auth-wall-detect.js) using three-heuristic AND logic: domain cookies exist, URL matches auth patterns, and DOM contains login elementsgotoaction - when an auth wall is detected, automatically closes headless browser and relaunches in headed mode for a checkpoint--no-auth-wall-detectopt-out flagauthWallDetectedandcheckpointCompletedfields in goto response when triggeredTest Plan
Related Issues
Closes #34