fix: support BGE-M3 embedding (dense_embedding fallback)#169
Merged
jinliyl merged 1 commit intoagentscope-ai:mainfrom Mar 20, 2026
Merged
Conversation
BGE-M3 returns dense_embedding instead of embedding; use dense_embedding as fallback when embedding is None to avoid TypeError. Made-with: Cursor
|
AleksandrMordvinov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Member
|
LGTM |
jinliyl
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BGE-M3 returns
dense_embeddinginstead ofembedding; ReMe expectsembeddingand causesTypeError: object of type 'NoneType' has no len().This adds a fallback in
_get_embeddingsto usedense_embeddingwhenembeddingis None.Related: CoPaw PR #1780 (which used a monkey-patch; this fixes the root cause in ReMe).
Made with Cursor