Skip to content

fix: support BGE-M3 embedding (dense_embedding fallback)#169

Merged
jinliyl merged 1 commit intoagentscope-ai:mainfrom
FUYOH666:fix/bge-m3-dense-embedding-support
Mar 20, 2026
Merged

fix: support BGE-M3 embedding (dense_embedding fallback)#169
jinliyl merged 1 commit intoagentscope-ai:mainfrom
FUYOH666:fix/bge-m3-dense-embedding-support

Conversation

@FUYOH666
Copy link
Contributor

BGE-M3 returns dense_embedding instead of embedding; ReMe expects embedding and causes TypeError: object of type 'NoneType' has no len().

This adds a fallback in _get_embeddings to use dense_embedding when embedding is None.

Related: CoPaw PR #1780 (which used a monkey-patch; this fixes the root cause in ReMe).

Made with Cursor

BGE-M3 returns dense_embedding instead of embedding; use dense_embedding
as fallback when embedding is None to avoid TypeError.

Made-with: Cursor
@cla-assistant
Copy link

cla-assistant bot commented Mar 19, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


AleksandrMordvinov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jinliyl
Copy link
Member

jinliyl commented Mar 19, 2026

LGTM

@jinliyl jinliyl merged commit 33f6822 into agentscope-ai:main Mar 20, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants