Fix finite-difference gradient calculation after redefining f(v)Fix finite difference gradient code after redefining f as f(v) #10
+29
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #9.
In the notebook, f(x, y) is defined first, but later f is redefined to take
a single vector v containing [x, y]. The finite-difference gradient section
still uses the scalar form f(x, y), causing a TypeError ("f() takes 1 positional
argument but 2 were given").
This fix updates the finite-difference code to call f(v) correctly by
constructing vector inputs. The numerical gradients now match the autograd
results.