Skip to content

Conversation

@bertramwooster
Copy link

No description provided.

@ageron
Copy link
Owner

ageron commented Nov 8, 2025

Hi @bertramwooster ,
Thanks for the PR, that's great. However, could you please remove tools_numpy.ipynb from the PR?

@ageron
Copy link
Owner

ageron commented Nov 17, 2025

Hi @bertramwooster ,
It looks like you've added another file to this PR. Could you please include only poetry.lock? If the other files need changes, please submit separate PRs. Thanks!

@bertramwooster
Copy link
Author

Hi @bertramwooster , It looks like you've added another file to this PR. Could you please include only poetry.lock? If the other files need changes, please submit separate PRs. Thanks!

@ageron I've converted pyproject.toml to Poetry format with all 56+ dependencies preserved, plus the lock file. Ready for review.

@ageron
Copy link
Owner

ageron commented Nov 18, 2025

Hi @bertramwooster ,
Thanks for that! Could you please remove the tools_pandas.ipynb file from the PR?

@ageron
Copy link
Owner

ageron commented Nov 20, 2025

Hi @bertramwooster ,
It looks like you are commiting various things to the same branch as this PR, and as a result they are appearing here, so I cannot merge the Poetry change without also merging all the rest. Could you please put the changes in separate branches?
Also, I tried the new pyproject.toml file, but it no longer works with the uv workflow. I'm happy to support Poetry along with uv, but I don't want to drop uv support. Do you know how to make a pyproject.toml file that supports both? Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants