This repository has been archived by the owner on Sep 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stefan-Ethernal
force-pushed
the
feat/introduce-consolidated-ci
branch
3 times, most recently
from
December 7, 2023 10:33
7a4d59e
to
473ad62
Compare
Stefan-Ethernal
force-pushed
the
feat/introduce-consolidated-ci
branch
from
December 7, 2023 11:22
473ad62
to
ec167aa
Compare
Stefan-Ethernal
force-pushed
the
feat/introduce-consolidated-ci
branch
from
December 7, 2023 11:39
f868133
to
ea55803
Compare
Stefan-Ethernal
force-pushed
the
feat/introduce-consolidated-ci
branch
from
December 7, 2023 11:58
62d634c
to
946dbc6
Compare
Stefan-Ethernal
force-pushed
the
feat/introduce-consolidated-ci
branch
from
December 8, 2023 11:10
d25a826
to
52e976f
Compare
Stefan-Ethernal
force-pushed
the
feat/introduce-consolidated-ci
branch
from
December 8, 2023 11:11
52e976f
to
c7e00e5
Compare
Kudos, SonarCloud Quality Gate passed! |
vcastellm
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if the coverage trick is working.
Not sure anymore, for some reason it doesn't display coverage information in this comment, but I can see some coverage info when I navigate to SonarCloud (https://sonarcloud.io/summary/new_code?id=0xPolygon_beethoven&pullRequest=24). I'd like to merge this PR and try to fix coverage if possible through a follow-up one if that makes sense. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR introduces consolidated CI GH workflow, that consists of:
beethoven
binarySonar Cloud GH action integration resources