Skip to content
This repository has been archived by the owner on Sep 23, 2024. It is now read-only.

Introduce consolidated CI #24

Merged
merged 16 commits into from
Dec 13, 2023
Merged

Conversation

Stefan-Ethernal
Copy link
Contributor

@Stefan-Ethernal Stefan-Ethernal commented Dec 7, 2023

The PR introduces consolidated CI GH workflow, that consists of:

  • building the beethoven binary
  • linter check
  • unit tests execution
    • sonar cloud scanning
  • e2e tests execution

Sonar Cloud GH action integration resources

@Stefan-Ethernal Stefan-Ethernal force-pushed the feat/introduce-consolidated-ci branch 3 times, most recently from 7a4d59e to 473ad62 Compare December 7, 2023 10:33
@Stefan-Ethernal Stefan-Ethernal force-pushed the feat/introduce-consolidated-ci branch from 473ad62 to ec167aa Compare December 7, 2023 11:22
@Stefan-Ethernal Stefan-Ethernal force-pushed the feat/introduce-consolidated-ci branch from f868133 to ea55803 Compare December 7, 2023 11:39
@Stefan-Ethernal Stefan-Ethernal force-pushed the feat/introduce-consolidated-ci branch from 62d634c to 946dbc6 Compare December 7, 2023 11:58
@Stefan-Ethernal Stefan-Ethernal force-pushed the feat/introduce-consolidated-ci branch from d25a826 to 52e976f Compare December 8, 2023 11:10
@Stefan-Ethernal Stefan-Ethernal force-pushed the feat/introduce-consolidated-ci branch from 52e976f to c7e00e5 Compare December 8, 2023 11:11
@Stefan-Ethernal Stefan-Ethernal self-assigned this Dec 8, 2023
@Stefan-Ethernal Stefan-Ethernal requested a review from a team December 8, 2023 14:05
@Stefan-Ethernal Stefan-Ethernal marked this pull request as ready for review December 8, 2023 14:05
Copy link

sonarqubecloud bot commented Dec 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the coverage trick is working.

@Stefan-Ethernal
Copy link
Contributor Author

LGTM if the coverage trick is working.

Not sure anymore, for some reason it doesn't display coverage information in this comment, but I can see some coverage info when I navigate to SonarCloud (https://sonarcloud.io/summary/new_code?id=0xPolygon_beethoven&pullRequest=24).

I'd like to merge this PR and try to fix coverage if possible through a follow-up one if that makes sense.

@Stefan-Ethernal Stefan-Ethernal merged commit f84f460 into main Dec 13, 2023
7 checks passed
@Stefan-Ethernal Stefan-Ethernal deleted the feat/introduce-consolidated-ci branch December 13, 2023 15:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants