Skip to content
This repository has been archived by the owner on Sep 23, 2024. It is now read-only.

New LXLY contract calls #38

Merged
merged 19 commits into from
Jan 12, 2024
Merged

New LXLY contract calls #38

merged 19 commits into from
Jan 12, 2024

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Jan 9, 2024

No description provided.

Base automatically changed from vcastellm/refactor_rpc to main January 10, 2024 11:30
@nivida nivida marked this pull request as ready for review January 10, 2024 12:51
Copy link
Contributor

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, leaving some minor comments to consider.

tx/tx.go Outdated Show resolved Hide resolved
rpc/rpc.go Outdated Show resolved Hide resolved
etherman/etherman.go Outdated Show resolved Hide resolved
etherman/etherman.go Outdated Show resolved Hide resolved
etherman/etherman.go Outdated Show resolved Hide resolved
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@nivida nivida merged commit 6356805 into main Jan 12, 2024
5 of 6 checks passed
@nivida nivida deleted the new-lxly-contract-call branch January 12, 2024 11:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants