Skip to content
This repository has been archived by the owner on Sep 23, 2024. It is now read-only.

Fix config defaults #47

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Fix config defaults #47

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7c2cb40
Fix config defaults
vcastellm Jan 22, 2024
98f1509
Fix test
vcastellm Jan 22, 2024
7c5cfeb
Fix linter
vcastellm Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions config/config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
package config

import (
"testing"

"github.com/stretchr/testify/assert"
"github.com/urfave/cli/v2"
)

func TestLoad(t *testing.T) {
ctx := cli.NewContext(nil, nil, nil)
ctx.Set(FlagCfg, "/path/to/config.yaml")

Check failure on line 12 in config/config_test.go

View workflow job for this annotation

GitHub Actions / Linter Analysis / Execution 

Error return value of `ctx.Set` is not checked (errcheck)

_, err := Load(ctx)
assert.NoError(t, err)
}
2 changes: 1 addition & 1 deletion config/default.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import (
// DefaultValues is the default configuration
const DefaultValues = `
[FullNodeRPCs]
0x0DCd1Bf9A1b36cE34237eEaFef220932846BCD82 = "http://zkevm-node:8123"
1 = "http://zkevm-node:8123"

[RPC]
Host = "0.0.0.0"
Expand Down
Loading